-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can not close or mention issues via commit #3848
Comments
This seems weird. Do the logs say anything? |
@thehowl no logs about this issue. does this needs some git-hooks let it work or something else. |
No, this should work out of the box. Was the issue actually created before you made the attempt to close it?
…On 27 April 2018 03:03:42 CEST, Qibang ***@***.***> wrote:
@thehowl no logs about this issue. does this needs some git-hooks let
it work or something else.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#3848 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Yes it is. I have create 140 issues before and this happened in the other repo too. |
To hopefully clarify a bit, commits should open/close issues when directly pushed to a repo, but do not affect issues if they were merged into a repo from a pull request. Once merged, #3695 will hook up the latter functionality. |
@thehowl Hows going. We need this working as expected. If I can help out please tell me what should I do. Thanks |
No, I still haven't quite understood why this is happening. Can you perhaps link us the repository where this happens? @krrutkow This does not seem to be the case; as you can see from the screenshot on top, there is no merge commit, so it's not a merge from a pull request. |
@thehowl the repo are private so can not access from public network |
Another possibility is that gitea's git hooks are not properly set up for the repository. If they are not present or if they lack the proper read+execute permissions they will not trigger events in gitea when pushes are made to the repository. |
update git hooks now works |
I think I observe the same symptoms (but maybe I have the wrong expectations about how the system works ?) |
[x]
):Description
I am upgrade from gogs to gitea last month, everything looks fine ATM. but today I found I can not close issue via commit or make reference.
But the link
#1
is correct can jump to the issue 1.Screenshots
The text was updated successfully, but these errors were encountered: