Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not close or mention issues via commit #3848

Closed
2 of 7 tasks
BANG88 opened this issue Apr 25, 2018 · 11 comments
Closed
2 of 7 tasks

Can not close or mention issues via commit #3848

BANG88 opened this issue Apr 25, 2018 · 11 comments

Comments

@BANG88
Copy link

BANG88 commented Apr 25, 2018

  • Gitea version (or commit ref): 1.4.0
  • Git version: latest
  • Operating system: Windows
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:

Description

I am upgrade from gogs to gitea last month, everything looks fine ATM. but today I found I can not close issue via commit or make reference.

But the link #1 is correct can jump to the issue 1.

Screenshots

screenshot at apr 25 17-37-13

screenshot at apr 25 17-36-37

@thehowl
Copy link
Contributor

thehowl commented Apr 26, 2018

This seems weird. Do the logs say anything?

@BANG88
Copy link
Author

BANG88 commented Apr 27, 2018

@thehowl no logs about this issue. does this needs some git-hooks let it work or something else.

@thehowl
Copy link
Contributor

thehowl commented Apr 27, 2018 via email

@BANG88
Copy link
Author

BANG88 commented Apr 27, 2018

Yes it is. I have create 140 issues before and this happened in the other repo too.

@krrutkow
Copy link
Contributor

To hopefully clarify a bit, commits should open/close issues when directly pushed to a repo, but do not affect issues if they were merged into a repo from a pull request.

Once merged, #3695 will hook up the latter functionality.

@BANG88
Copy link
Author

BANG88 commented May 2, 2018

@thehowl Hows going. We need this working as expected. If I can help out please tell me what should I do.

Thanks

@thehowl
Copy link
Contributor

thehowl commented May 3, 2018

No, I still haven't quite understood why this is happening. Can you perhaps link us the repository where this happens?

@krrutkow This does not seem to be the case; as you can see from the screenshot on top, there is no merge commit, so it's not a merge from a pull request.

@BANG88
Copy link
Author

BANG88 commented May 3, 2018

@thehowl the repo are private so can not access from public network

@krrutkow
Copy link
Contributor

krrutkow commented May 5, 2018

Another possibility is that gitea's git hooks are not properly set up for the repository. If they are not present or if they lack the proper read+execute permissions they will not trigger events in gitea when pushes are made to the repository.

@BANG88
Copy link
Author

BANG88 commented May 5, 2018

update git hooks now works

@pcopissa
Copy link

pcopissa commented Oct 10, 2018

I think I observe the same symptoms (but maybe I have the wrong expectations about how the system works ?)
Here are the steps I do (on Gitea 1.5.2):
Create an issue (#1 in my case...). Issue shows as "open".
Added + committed + pushed some file with a comment "fixes #1" into master.
I expected to see the issue change to "close" but it didn't not. I tried quite a few variant (fixes: #1, Fixes #1, Fixes: #1, fix #1 and countless others and none worked as I expected)
Is closing an issue from a commit / push possible ? If so how ?

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants