You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It adds a brand new importer for Gitea!
This is a continuation of !6945 started by @bkc.
Gitea aims to be 100% GitHub-compatible but there's a few differences:
- Gitea is not an OAuth provider (yet): go-gitea/gitea#27
- This means we cannot map Gitea users given an assignee ID => assignees are not set on imported issues and merge requests
- No releases API for now: go-gitea/gitea#330
- API version is `v1` (GitHub is `v3`)
- The IID field for milestones is `id` compared to `number` in GitHub.
- Issues, PRs, milestones, labels don't have a `url` field (the importer now fallback to `''` in that case)
**Known issues:**
- Comments are not imported because comments JSON always have a blank `html_url`/`issue_url`/`pull_request_url`, so the IID cannot be extracted and the issuable cannot be found... :( This is tracked in go-gitea/gitea#401, and solved by gogs/gogs#3624 but this needs to be submitted / merged in Gitea.
This is noted in the documentation.
## Are there points in the code the reviewer needs to double check?
1. I've made `Import::GiteaController` inherit from `Import::GithubController` since both controllers should be identical in the long-term and their current differences are small.
1. I've added a base `IssuableFormatter` class from which `IssueFormatter` & `PullRequestFormatter` inherit
1. I've added shared examples for GitHub/Gitea importer classes
1. I've made `Gitlab::ImportSources` more robust and tested! 🎄
1. I've added routing specs for import routes! 🎄
Closes #22348
See merge request !8116
gitea/models/issue_comment.go
Lines 127 to 135 in 8aeeed0
Description
As of 8aeeed0, the Issue model doesn't expose
HTMLURL
,IssueURL
, andPRURL
in theApiFormat
function:gitea/models/issue_comment.go
Lines 127 to 135 in 8aeeed0
gogs/gogs#3624 has been submitted on Gogs but should be submitted on Gitea now.
Thanks in advance, it will help us having a more useful Gitea importer for GitLab (https://gitlab.com/gitlab-org/gitlab-ce/issues/22348).
/cc @bkcsoft
The text was updated successfully, but these errors were encountered: