Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Issues are missing HTMLURL, IssueURL, and PRURL #401

Closed
rymai opened this issue Dec 16, 2016 · 0 comments · Fixed by #449
Closed

[API] Issues are missing HTMLURL, IssueURL, and PRURL #401

rymai opened this issue Dec 16, 2016 · 0 comments · Fixed by #449
Labels
Milestone

Comments

@rymai
Copy link

rymai commented Dec 16, 2016

  • Gitea version (or commit ref):
    func (c *Comment) APIFormat() *api.Comment {
    return &api.Comment{
    ID: c.ID,
    Poster: c.Poster.APIFormat(),
    Body: c.Content,
    Created: c.Created,
    Updated: c.Updated,
    }
    }

Description

As of 8aeeed0, the Issue model doesn't expose HTMLURL, IssueURL, and PRURL in the ApiFormat function:

func (c *Comment) APIFormat() *api.Comment {
return &api.Comment{
ID: c.ID,
Poster: c.Poster.APIFormat(),
Body: c.Content,
Created: c.Created,
Updated: c.Updated,
}
}
but the Go SDK already expect those fields: https://github.com/go-gitea/go-sdk/blob/master/gitea/issue_comment.go#L15-L24

gogs/gogs#3624 has been submitted on Gogs but should be submitted on Gitea now.

Thanks in advance, it will help us having a more useful Gitea importer for GitLab (https://gitlab.com/gitlab-org/gitlab-ce/issues/22348).

/cc @bkcsoft

@lunny lunny added the type/bug label Dec 16, 2016
@lunny lunny added this to the 1.0.0 milestone Dec 16, 2016
dbalexandre pushed a commit to gitlabhq/gitlabhq that referenced this issue Dec 21, 2016
It adds a brand new importer for Gitea!

This is a continuation of !6945 started by @bkc.

Gitea aims to be 100% GitHub-compatible but there's a few differences:

- Gitea is not an OAuth provider (yet): go-gitea/gitea#27
  - This means we cannot map Gitea users given an assignee ID => assignees are not set on imported issues and merge requests
- No releases API for now: go-gitea/gitea#330
- API version is `v1` (GitHub is `v3`)
- The IID field for milestones is `id` compared to `number` in GitHub.
- Issues, PRs, milestones, labels don't have a `url` field (the importer now fallback to `''` in that case)

**Known issues:**

- Comments are not imported because comments JSON always have a blank `html_url`/`issue_url`/`pull_request_url`, so the IID cannot be extracted and the issuable cannot be found... :( This is tracked in go-gitea/gitea#401, and solved by gogs/gogs#3624 but this needs to be submitted / merged in Gitea.

This is noted in the documentation.

## Are there points in the code the reviewer needs to double check?

1. I've made `Import::GiteaController` inherit from `Import::GithubController` since both controllers should be identical in the long-term and their current differences are small.
1. I've added a base `IssuableFormatter` class from which `IssueFormatter` & `PullRequestFormatter` inherit
1. I've added shared examples for GitHub/Gitea importer classes
1. I've made `Gitlab::ImportSources` more robust and tested! 🎄 
1. I've added routing specs for import routes! 🎄 

Closes #22348

See merge request !8116
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants