Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook for pull request review approve/reject events #4986

Closed
2 of 7 tasks
technomagos opened this issue Sep 27, 2018 · 0 comments · Fixed by #5027
Closed
2 of 7 tasks

Webhook for pull request review approve/reject events #4986

technomagos opened this issue Sep 27, 2018 · 0 comments · Fixed by #5027
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.7.0

Comments

@technomagos
Copy link

  • Gitea version (or commit ref):
    Latest master build
  • Git version: n/a
  • Operating system: linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

When pressing the Approve or Reject buttons in pull-request Review, no webhook seems to be triggered. Will be good to wire those up, so an external process can be notified of them

Thanks
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 28, 2018
@lunny lunny added this to the 1.x.x milestone Sep 28, 2018
@lafriks lafriks changed the title bug : no webhook called on pull request review approve/reject buttons Webhook for pull request review approve/reject events Sep 28, 2018
@adelowo adelowo mentioned this issue Oct 6, 2018
Merged
3 tasks
@lafriks lafriks modified the milestones: 1.x.x, 1.7.0 Dec 28, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Webhook for Pull Request approval/rejection adelowo/gitea
3 participants
@lunny @lafriks @technomagos