Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook for Pull Request approval/rejection #5027

Merged
merged 23 commits into from
Dec 27, 2018
Merged

Webhook for Pull Request approval/rejection #5027

merged 23 commits into from
Dec 27, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Oct 6, 2018 •
edited
Loading

Fixes #4986

Format web hook for

  • Slack
  • Discord
  • Dingtalk

Here is an example of what it looks like on Slack

lol

@codecov-io
Copy link

codecov-io commented Oct 6, 2018 •
edited
Loading

Codecov Report

Merging #5027 into master will decrease coverage by 0.07%.
The diff coverage is 4.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5027      +/-   ##
==========================================
- Coverage   37.59%   37.51%   -0.08%     
==========================================
  Files         322      322              
  Lines       47337    47458     +121     
==========================================
+ Hits        17794    17802       +8     
- Misses      26985    27099     +114     
+ Partials     2558     2557       -1
Impacted Files Coverage Δ
models/webhook.go 68.71% <ø> (ø) ⬆️
models/webhook_dingtalk.go 0% <0%> (ø) ⬆️
models/webhook_discord.go 1.4% <0%> (-0.16%) ⬇️
models/webhook_slack.go 0% <0%> (ø) ⬆️
models/review.go 53.08% <16.66%> (-6.7%) ⬇️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb0a6f...25f4aac. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2018
@techknowlogick techknowlogick added this to the 1.7.0 milestone Oct 6, 2018
appleboy
appleboy previously requested changes Oct 9, 2018
View reviewed changes
@appleboy appleboy added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 9, 2018
@adelowo adelowo force-pushed the webhook_for_pr_approval_rejection branch from 8a8c216 to 67259f0 Compare October 9, 2018 14:34
@lafriks
Copy link
Member

lafriks commented Oct 9, 2018

shouln't there be also webhook on pull request code comment?

@adelowo
Copy link
Member Author

adelowo commented Oct 9, 2018

Whoops.... I thought it might not be needed, will fix

@kolaente
Copy link
Member

shouln't there be also webhook on pull request code comment?

We already have issue comment webhooks, should be fairly easy to implement these for prs.

@adelowo
Copy link
Member Author

adelowo commented Oct 20, 2018 •
edited
Loading

Yeah, @kolaente... I was a little too busy, would update this by tomorrow

@adelowo
Copy link
Member Author

adelowo commented Oct 23, 2018

Done @lafriks and @kolaente... Ready for review 😃😃

@lunny
Copy link
Member

lunny commented Dec 11, 2018

file conflicted

@adelowo adelowo force-pushed the webhook_for_pr_approval_rejection branch from fa08989 to 50e0ae1 Compare December 11, 2018 12:20
@lafriks
Copy link
Member

lafriks commented Dec 27, 2018

@appleboy can you review again?

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2018
@techknowlogick techknowlogick dismissed appleboy’s stale review December 27, 2018 17:54

Changes have been made

@techknowlogick techknowlogick merged commit 945804f into go-gitea:master Dec 27, 2018
@adelowo adelowo deleted the webhook_for_pr_approval_rejection branch December 27, 2018 18:46
@lunny lunny added the type/changelog Adds the changelog for a new Gitea version label Dec 28, 2018
@lunny lunny mentioned this pull request Feb 6, 2019
Closed
13 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

@appleboy appleboy appleboy left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Webhook for pull request review approve/reject events
9 participants
@adelowo @codecov-io @lafriks @kolaente @lunny @appleboy @techknowlogick @bkcsoft @delvh