-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Gitea to have themes #56
Comments
@DblK your idea is only change color or html components too? |
With Semantic you can do both (See http://semantic-ui.com/usage/theming.html). |
theme with material design sounds good |
I was actually thinking about a material theme too. I'd like to join the discussion here. |
switched to enhancement as we agree on benefits of this idea :) |
I'm planning on tackling this issue (or at least #730) , and I thought about implementing a button close to the language button on the bottom of the page, which would be used to choose theming. Any thoughts on this? |
Does anybody suggest a way to pack themes? The css-only version of semantic-ui, which gitea uses, apparently is not made to support themes. Do you guys have any ideas on how to approach this? |
I remember someone have provide a github-like theme. |
Just pack the theme into a single CSS file, and apply it over the existing theme. It usually works fine. |
No. It's a Gitea patch which could just replace for a github-like theme. |
@lunny here is some CSS which can be appended to the page. It is taken from the example, and makes gitea look like github. http://pastebin.com/NJF5wg9W Is this the kind of thing you want? |
@geek1011 Maybe, but how did you build it? I mean, it is way over 10 000 lines. EDIT: nervermind, didn't see you got it from the example. |
@gabrielsimoes I just concatenated a the CSS files in the example. |
The issue I encountered is the following: the Semantic UI build tools allows to build a custom .css file using a theme which overrides the default one. That is, a single css file containing all the Semantic UI css with your changes included. I think editing the css manually is just too time consuming. I think the ideal way would be to build a custom css per theme. This also affects custom css which are added to gitea through What I propose is the following: reimplement the gitea custom less files as a Semantic UI theme, and auto compile it to separate semantic UI css for each theme. If someone wants to build its own theme, it should override this gitea theme, and build a custom css for it. This custom css would be loaded to the page instead of the default theme css, and so on. I mean, the css files would not be used as an override to a default css, as this is not supported by Semantic UI build tools. Instead, a themer (or whatever)should use the Semantic UI build tools to create a custom css for his theme which includes all the Semantic UI css. |
Would it be a problem to have the Semantic UI "distribution" inside gitea? So that themes can be generated together with the files inside |
I don't see any issues |
Any news on this? |
Nobody work on this. @kolaente |
FYI: I've created simple github-like theme for gitea However, it would be good to have some kind of documentation how to generate css from less files, to help make themes easier |
Maybe we could give some proposals. We could define a |
I don't think themes should replace css file, it should just change existing styles by being added as additional css file, otherwise with base css file changed themes will become outdated as will have missing styles |
I did a POC for a theme, with the css inside the public directory. |
@lafriks That would mean we dont use Semantic-UI's themeing but own css files which are added after the base css? |
Since we use semantic-ui and it can handle themes, Gitea should provide the default theme and a dark theme also.
Users will be able to make their own theme too.
I would suggest to begin with only css tweaks to change the display of pages.
In a second step, maybe we can add themes to modify templates file (.tmpl) to modify the links on each page.
What do you think about that?
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/38935464-allow-gitea-to-have-themes?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).The text was updated successfully, but these errors were encountered: