Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org-mode support #5710

Closed
Iced-Sun opened this issue Jan 13, 2019 · 7 comments
Closed

org-mode support #5710

Iced-Sun opened this issue Jan 13, 2019 · 7 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@Iced-Sun
Copy link

It seems to me that goorgeous may be dead. There is a PR for hugo which introduces an alternative implementation go-org. Here is a demo page shows the html output of goorgeous (left side) and go-org (right side).

#5430, #3122 should receive immediate fixes if go-org is adopted.

Regards.

@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 13, 2019
@lunny
Copy link
Member

lunny commented Jan 16, 2019

wait for that PR merged. :)

@lunny lunny added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jan 31, 2019
@michael-k
Copy link

PR has been merged in commit gohugoio/hugo@fad183c

@lunny lunny removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jun 8, 2019
@stale
Copy link

stale bot commented Aug 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 7, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 7, 2019
@stale stale bot removed the issue/stale label Aug 7, 2019
matthijsk added a commit to matthijsk/dotemacs that referenced this issue Aug 12, 2019
At the time of writing, the Gitea org mode parser cannot handle lower case
org-mode structure blocks, which breaks display of org files in the web
interface.

Should be fixed when issue go-gitea/gitea#5710 is
resolved.

As a workaround, simply make sure the structure blocks are upper case (which
they used to be before org-mode 9.2).
@Ekleog
Copy link

Ekleog commented Sep 9, 2019

Not sure whether the stale bot is still threatening closing as it appears to have removed the stale label since the reviewed/confirmed tag was put, but this is still an issue.

goorgeous, in addition to the bug described by #3122, is also not generating a table of contents, which go-org does. (I am also not sure whether go-org does provide syntax highlighting, as their screenshot does it but not their demo, so… meh)

@niklasfasching
Copy link

niklasfasching commented Sep 11, 2019

there's a hook for syntax highlighting but go-org itself doesn't bundle anything - for the github pages examples I'm using chroma.

If no one is looking into this i can take a look next week.

This is how hugo uses go-org and the most basic usage would be

config := org.New()
writer := org.NewHTMLWriter()
html, err := config.Parse(reader, path).Write(writer)

to add syntax highlighting you can probably pretty much copy this highlight function

@niklasfasching
Copy link

The development setup seems quite heavy and I have a shitty old laptop - I'm happy to help if you run into any problems but won't take a stab at adding support myself, sorry.

@Iced-Sun
Copy link
Author

Per #8560

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants