Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to set labels on issues #6191

Closed
silverwind opened this issue Feb 26, 2019 · 5 comments · Fixed by #6194
Closed

Unable to set labels on issues #6191

silverwind opened this issue Feb 26, 2019 · 5 comments · Fixed by #6194
Labels
type/bug
Milestone
1.8.0

Comments

@silverwind
Copy link
Member

silverwind commented Feb 26, 2019 •
edited
Loading

Reproduced on https://try.gitea.io/silverwind/symlink-test/issues/1, but should affect any issue.

  1. Create new issue without any labels
  2. Try to set a 'bug' label by clicking it in the dropdown and closing the dropdown by clicking outside
  3. Page initially shows the label, but then reloads and label is gone

Maybe related to #5980 @jolheiser.
@lunny
Copy link
Member

lunny commented Feb 26, 2019

Cannot reproduce on your link! macOS chrome

@silverwind
Copy link
Member Author

Hmm, looks to affect Firefox only, testing further.

@jolheiser
Copy link
Member

Isn't Javascript just so much fun?
Is there any error in browser dev console?

@silverwind silverwind mentioned this issue Feb 26, 2019
Merged
@silverwind
Copy link
Member Author

Issue found, it is a race condition between location.reload and updateIssueMeta (which is async). I guess it only worked by sheer luck in Chrome.

silverwind added a commit to silverwind/gitea that referenced this issue Feb 26, 2019
@silverwind
fix issue update race condition
dee5852 
fixes: go-gitea#6191
@jolheiser
Copy link
Member

Ah, shoot. Thanks for the catch!

@lunny lunny added the type/bug label Feb 27, 2019
@lunny lunny added this to the 1.8.0 milestone Feb 27, 2019
zeripath pushed a commit that referenced this issue Feb 28, 2019
@silverwind @zeripath
UI: Fix race in update issue labels and assignees (#6194)
8e266c3 
Fix #6191 

* fix issue update race condition
* fix similar race same race when clearing assignee
* always load promise polyfill
* replace es6-promise with promise-polyfill
* move promise-polyfill to <head>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

UI: Fix issue update race condition silverwind/gitea
3 participants
@lunny @silverwind @jolheiser