You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Run an gitea server at local, and login as sysadmin;
Create an private organization;
Create an repo in the organization;
Search the repo at homepage of the organization;
See No matching repositories found.
http://gitea.xxx/orag1?q=rep&tab=&sort=recentupdate
a. Search repos in an private organization should return repos if I'm sysadmin(even if I'm also owner or member of the organization), like it does without keyword or it does for normal members.
d. SearchRepositoryByName use the same param OwnerID for search target and access check for org, and may not work well if they should be different.(Not the same as a, since sysadmin should simply skip all access check)
Screenshots
The text was updated successfully, but these errors were encountered:
yyjdelete
changed the title
Search repos with keyword in homepage of organization should work for private organization
Search repos with keyword in homepage of organization should work for private organization and owner
Apr 18, 2019
yyjdelete
changed the title
Search repos with keyword in homepage of organization should work for private organization and owner
Search repos with keyword in homepage of organization should work for private organization and sysadmin
Apr 18, 2019
[x]
):Description
Related to the func added in #5986, #1763.
See
No matching repositories found.
http://gitea.xxx/orag1?q=rep&tab=&sort=recentupdate
a. Search repos in an private organization should return repos if I'm sysadmin(even if I'm also owner or member of the organization), like it does without keyword or it does for normal members.
b. And found
"user.id"
shouldn't be use as parameter of sql here in sql log.https://github.com/go-gitea/gitea/blob/v1.8.0-rc3/models/repo_list.go#L208
c.
orderBy
not work whenctx.IsSigned && !ctx.User.IsAdmin
https://github.com/go-gitea/gitea/blob/v1.8.0-rc3/routers/user/home.go#L438-L481
d.
SearchRepositoryByName
use the same paramOwnerID
for search target and access check for org, and may not work well if they should be different.(Not the same as a, since sysadmin should simply skip all access check)Screenshots
The text was updated successfully, but these errors were encountered: