Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue tags eg "#1" vs "someprefix#1" #7438

Closed
flobee opened this issue Jul 12, 2019 · 6 comments · Fixed by #7444
Closed

issue tags eg "#1" vs "someprefix#1" #7438

flobee opened this issue Jul 12, 2019 · 6 comments · Fixed by #7444
Labels
Milestone

Comments

@flobee
Copy link

flobee commented Jul 12, 2019

Description

in this issue2 should not be marked within the commit which belongs to issue1
I think for a work around could be writing KB\#2 but feels uncomfortable and dont work. How to?

Kind regards

@Cherrg
Copy link
Contributor

Cherrg commented Jul 12, 2019

(Note: This does happen here on github too
e.g.: #6371 references to #(1-10))

@Cherrg
Copy link
Contributor

Cherrg commented Jul 12, 2019

may it is possible to link commits only when there is a space or linestart before #

@mrsdizzie
Copy link
Member

Hmm yea it shouldn't be doing that, will look and send a fix

mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Jul 12, 2019
Use same regex as markup for matching in commits.

Fixes go-gitea#7438
lunny pushed a commit that referenced this issue Jul 14, 2019
* Fix regex for issues in commit messages

Use same regex as markup for matching in commits.

Fixes #7438

* make fmt
mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Jul 14, 2019
* Fix regex for issues in commit messages

Use same regex as markup for matching in commits.

Fixes go-gitea#7438

* make fmt
zeripath pushed a commit that referenced this issue Jul 14, 2019
* Fix regex for issues in commit messages

Use same regex as markup for matching in commits.

Fixes #7438

* make fmt
@flobee
Copy link
Author

flobee commented Jul 17, 2019

Is there an update script to update records from the past 👎 👍 ? It seems the content get static after a push was made :~/

@mrsdizzie
Copy link
Member

@flobee Unfortunately not as it wouldn't necessarily know what was added there for what reason.

You could manually remove them from the DB and you can find those type of mention comments like this:

SELECT * from comment WHERE type = 4;

Or you could search for the specific string in the example in this issue:

SELECT * from comment WHERE type = 4 AND content LIKE '%KB#%';

type 4 is a commit reference which is where this bug was

@flobee
Copy link
Author

flobee commented Jul 17, 2019

thx!

@lunny lunny added the type/bug label Jul 18, 2019
@lunny lunny modified the milestones: 1.10.0, 1.9.0 Jul 18, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this issue Jul 18, 2019
* Fix regex for issues in commit messages

Use same regex as markup for matching in commits.

Fixes go-gitea#7438

* make fmt
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants