Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Branch View] some enhancements #7454

Closed
12 of 14 tasks
6543 opened this issue Jul 13, 2019 · 31 comments
Closed
12 of 14 tasks

[Branch View] some enhancements #7454

6543 opened this issue Jul 13, 2019 · 31 comments
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@6543
Copy link
Member

6543 commented Jul 13, 2019 •
edited
Loading

Tasks

Add info & Functions

related bugs

Improvements
@6543
Copy link
Member Author

6543 commented Jul 13, 2019

perhaps the other information is alo usefull (the tags, the commits behind/ahead) ...

@lunny
Copy link
Member

lunny commented Jul 13, 2019

This has been merged in #6990

@lunny lunny closed this as completed Jul 13, 2019
@lunny lunny reopened this Jul 13, 2019
@lunny
Copy link
Member

lunny commented Jul 13, 2019 •
edited
Loading

Something are absent.

  • commit id & commit message
  • time
  • if it's protected
  • download

@6543

This comment has been minimized.

Sign in to view
@lunny lunny changed the title show if branch is merged Branch view some enhancements Jul 13, 2019
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jul 13, 2019
@lunny
Copy link
Member

lunny commented Jul 13, 2019

@6543 title changed

@gary-kim
Copy link
Member

gary-kim commented Jul 14, 2019 •
edited
Loading

Sounds like a good idea. I'll see if I can work on this.

Something are absent.
time

Isn't time already there?

@gary-kim gary-kim mentioned this issue Jul 14, 2019
Merged
2 tasks
@lunny
Copy link
Member

lunny commented Jul 14, 2019

@gary-kim Oh. yes, time is already there.

@lunny lunny added the type/enhancement An improvement of existing functionality label Jul 14, 2019
@6543

This comment has been minimized.

Sign in to view
@6543
Copy link
Member Author

6543 commented Jul 17, 2019 •
edited
Loading

what do you think should it say merged when latest commit is in some other branch or if it is in default one?
@lunny @gary-kim @techknowlogick

@lunny
Copy link
Member

lunny commented Jul 18, 2019

partially fixed by #7461

@lunny
Copy link
Member

lunny commented Jul 18, 2019 •
edited
Loading

@6543 merged to which branch? Default branch?

@6543 6543 mentioned this issue Jul 18, 2019
Closed
5 tasks
@6543

This comment has been minimized.

Sign in to view
@lunny
Copy link
Member

lunny commented Jul 19, 2019

@6543 If a repository use pull request, the merged label is unusable. But for others with no pull request, merged label is very usable. I will find time to review your PR.

@6543 6543 mentioned this issue Jul 19, 2019
Closed
@6543

This comment has been minimized.

Sign in to view
@6543

This comment has been minimized.

Sign in to view
@6543

This comment has been minimized.

Sign in to view
@6543
Copy link
Member Author

6543 commented Jul 24, 2019

@lunny @gary-kim what do you think of PR 7520 curent state?

@lunny
Copy link
Member

lunny commented Jul 24, 2019

@6543 I have gave that L-G-T-M

6543 added a commit to 6543-forks/gitea that referenced this issue Jul 24, 2019
@6543
remove diff for merge
99470a8 
shuld be seperat handel (go-gitea#7530) was first step ... to go-gitea#7454 (duble protection symbole ...)
This was referenced Jul 24, 2019
Merged
Closed
Merged
@6543

This comment has been minimized.

Sign in to view
This was referenced Jul 25, 2019
Merged
Merged
@6543
Copy link
Member Author

6543 commented Jul 27, 2019

updated tasks list

@lunny
Copy link
Member

lunny commented Jul 29, 2019

@6543 added #7653 on task list

@6543
Copy link
Member Author

6543 commented Jul 29, 2019 •
edited
Loading

@6543 added #7653 on task list

ok this one line i could realy add to PR 7604 but i dont get it because it was realy out of topic ...

@6543 6543 mentioned this issue Jul 29, 2019
Merged
@6543
Copy link
Member Author

6543 commented Jul 31, 2019

I will be on a trip for a month, so I'm not mad when someone else does tasks :)

@lunny
Copy link
Member

lunny commented Jul 31, 2019 •
edited
Loading

@6543 Thanks for your work. Have a good time!

@6543
Copy link
Member Author

6543 commented Aug 25, 2019 •
edited
Loading

@lunny

@6543 If a repository use pull request, the merged label is unusable. But for others with no pull request, merged label is very usable. I will find time to review your PR.

so if the last commit is includet in default branch and folowing commit on default branch has a message wich *[Mm]erge*<branch name>* then it is merged manualy and the merge flag sould also aperar?
is that what you mean?

@6543
Copy link
Member Author

6543 commented Aug 25, 2019

and showing "New Pull Request" Button if there is nothing to merge is noncese (latest commit is included in default branch ...). if you click on it next page tells you: "These branches are equal. There is no need to create a pull request."

@lunny
Copy link
Member

lunny commented Aug 25, 2019

@6543 good catch

This was referenced Aug 25, 2019
Closed
Closed
@6543
Copy link
Member Author

6543 commented Aug 25, 2019

#7977 is ready to merge :D
and #7976 is way more complicated ...

@6543 6543 mentioned this issue Aug 26, 2019
Closed
@6543
Copy link
Member Author

6543 commented Aug 26, 2019

@lunny have a look at the PR(#7979)?

@6543 6543 mentioned this issue Sep 23, 2019
Closed
@6543
Copy link
Member Author

6543 commented Oct 10, 2019

Reverence PR #8449 -> a other todo will be checked soon

@6543 6543 changed the title Branch view some enhancements [Branch View] some enhancements Oct 14, 2019
@6543
Copy link
Member Author

6543 commented Oct 14, 2019

so it's time I'll close this huge one

lot of things work now ...
Thanks to al who helped me ...

@6543 6543 closed this as completed Oct 14, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @6543 @gary-kim