API: Added pull review read only endpoints #10005
Conversation
| Body string `json:"body"` | ||
| CommitID string `json:"commit_id"` | ||
| Type string `json:"type"` | ||
|
|
There was a problem hiding this comment.
can you add state info too?
"state": "APPROVED",There was a problem hiding this comment.
o it still a draft :D - the start looks good 👍
There was a problem hiding this comment.
I thought about naming that state, but it was so misleading, that I've gone with type.
"state":"COMMENT"
just looks strange.
But i can rename this if wanted.
There was a problem hiding this comment.
fair point ... just did a comparsion with the github api ...
and beside COMMENT, PENDING, APPROVED, REJECT could be interpreted as state ...
There was a problem hiding this comment.
But i can rename this if wanted.
please :)
There was a problem hiding this comment.
Maybe add field submitted_at?
There was a problem hiding this comment.
stale and official can also be interesting fields (GH doesn't have them).
Also possibility to get list of only latest review of each reviewer would be good, as that is what is seen on PR page.
GiteaBot
added
the
lgtm/need 2
|
@tbe GH API reference? |
|
@bagasme this PR is still a DRAFT and the link to github api docu is this: https://developer.github.com/v3/pulls/reviews |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
@tbe what's the status? |
|
@tbe am I allowed to take over this? |
|
ok I'll take this |
|
work will go on in #11224 |
API Endpoints for Reviews.
implements #5733