-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move highlight.js to npm/webpack #10011
Conversation
silverwind
commented
Jan 26, 2020
- introduced window.config to help with js-based lazy-loading
- adjusted webpack chunk naming to avoid 'vendors~name.js' that webpack defaults to for vendor chunks.
- added theme class to html and prefixed all selectors. this is neccesary so that the theme styles win over the lazy-loaded ones.
Edit: Fixed those by adding the parent selector to only those |
Rebased and did a few improvments. Good to go from my side. |
Codecov Report
@@ Coverage Diff @@
## master #10011 +/- ##
==========================================
- Coverage 42.27% 42.26% -0.01%
==========================================
Files 611 611
Lines 80407 80407
==========================================
- Hits 33989 33987 -2
- Misses 42239 42241 +2
Partials 4179 4179
Continue to review full report at Codecov.
|
- introduced window.config to help with js-based lazy-loading - adjusted webpack chunk naming to avoid 'vendors~name.js' that webpack defaults to for vendor chunks. - added theme class to html and prefixed all selectors. this is neccesary so that the theme styles win over the lazy-loaded ones.
|