Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix followers and following tabs in profile #10202

Merged
merged 2 commits into from
Feb 9, 2020

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Feb 9, 2020

Fixes #10195

Screenshot:
image

@lafriks lafriks added type/bug pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Feb 9, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #10202 into master will increase coverage by 0.21%.
The diff coverage is 4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10202      +/-   ##
==========================================
+ Coverage   43.42%   43.63%   +0.21%     
==========================================
  Files         576      576              
  Lines       79650    79682      +32     
==========================================
+ Hits        34586    34768     +182     
+ Misses      40788    40624     -164     
- Partials     4276     4290      +14
Impacted Files Coverage Δ
routers/user/profile.go 50.69% <0%> (-0.97%) ⬇️
routers/routes/routes.go 86.47% <100%> (-0.05%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/pull.go 32.43% <0%> (-1.51%) ⬇️
models/issue_label.go 63.79% <0%> (-0.69%) ⬇️
models/gpg_key.go 54.81% <0%> (-0.56%) ⬇️
routers/api/v1/repo/label.go 84% <0%> (+84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a4a1e...042db92. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2020
@6543
Copy link
Member

6543 commented Feb 9, 2020

@lafriks why is this a fix and not a normal enhancement?

EDIT: sory read the underlying issue - sure

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2020
@6543
Copy link
Member

6543 commented Feb 9, 2020

I would make a backport fix to 1.11.0 -> witch simply add followers and following to reservedUsernames in user.go

@lafriks lafriks merged commit fe00886 into go-gitea:master Feb 9, 2020
@lafriks lafriks deleted the fix/profile_tabs branch February 9, 2020 20:18
@lafriks
Copy link
Member Author

lafriks commented Feb 9, 2020

No need to add them to reserved usernames and that would not help anyway as problem is repository name

@lafriks
Copy link
Member Author

lafriks commented Feb 9, 2020

I can of course backport this to 1.11 if needed

lafriks added a commit to lafriks-fork/gitea that referenced this pull request Feb 9, 2020
@lafriks lafriks added backport/done All backports for this PR have been created backport/v1.11 labels Feb 9, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"followers" & "following" is a valid repository name
5 participants