-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate long commit message header #10301
Conversation
|
Hmm... If I stick this style on the appropriate element in templates/repo/view-list.tmpl then we get appropriate sizes.
|
OK I think it's fixed. @silverwind could you take a look? I've used 90vw - I dunno if that's allowed? |
Does it work with the CI icon shown? I'm still not a fan of CSS truncation here in general, it's always rather hackish because it's a table, not a flexbox. We could opt to do what GitHub does and make the header line a flexbox but that'd require a quite a few changes. |
90vw seems like an arbitrary value but if works in most cases, I guess I'm fine with such hacks until we can convert it to flexbox (then it's just |
@silverwind I guesss I've done that now. |
…a into fix-8900-wrap-long-message
Codecov Report
@@ Coverage Diff @@
## master #10301 +/- ##
==========================================
- Coverage 43.74% 43.71% -0.03%
==========================================
Files 585 585
Lines 81015 81015
==========================================
- Hits 35441 35419 -22
- Misses 41179 41212 +33
+ Partials 4395 4384 -11
Continue to review full report at Codecov.
|
* Truncate long commit message header * Fix overflow in view commit table * Use @media less * Further improvements * Fix the commit message on small screens * adjust width of minimal table
Fix #8900
Fix #10209