Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't manually replace whitespace during render (#10291) #10315

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Don't manually replace whitespace during render (#10291) #10315

merged 1 commit into from
Feb 17, 2020

Commits on Feb 17, 2020

  1. Don't manually replace whitespace during render (go-gitea#10291) 

    * Don't manually replace whitespace during render

For historical reasons Gitea manually alters the urlPrefix and replaces
a whitespace with a +. This Works for URLs, but we're also passing
urlPrefix to git calls and adding the + is breaking the tree path.

Goldmark will automatically convert a white space to the proper %20, so
we should leave the string as is which lets us pass it to git unmodified
and then let Goldmark fix it.

Also fixed separate bug in URLJoin I noticed while testing where it will
silently discard sections of a path that have # in them (possibly
others). We should just escape it first.

Fixes 10156

* Escape elems as well

* Revert "Escape elems as well"

This reverts commit 8bf4959.

* restart ci

* remove changes to URLJoin

* restart ci

Co-authored-by: techknowlogick <matti@mdranta.net>
    @mrsdizzie @techknowlogick
    mrsdizzie and techknowlogick committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    44a46ab View commit details
    Browse the repository at this point in the history