Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queue for code indexer #10332

Merged
merged 10 commits into from
Sep 7, 2020
Merged

Add queue for code indexer #10332

merged 10 commits into from
Sep 7, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 18, 2020

No description provided.

@lunny lunny added the type/enhancement An improvement of existing functionality label Feb 18, 2020
@lunny lunny added this to the 1.12.0 milestone Feb 18, 2020
@lunny lunny force-pushed the lunny/move_code_index_queue branch 2 times, most recently from aa8ad16 to 7717f2e Compare February 18, 2020 13:10
@lunny
Copy link
Member Author

lunny commented Feb 18, 2020

blocked by #10133.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2020
@stale
Copy link

stale bot commented Apr 18, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 18, 2020
@lafriks
Copy link
Member

lafriks commented Apr 18, 2020

@lunny ping

@stale stale bot removed the issue/stale label Apr 18, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 19, 2020
@lafriks lafriks modified the milestones: 1.12.0, 1.13.0 May 16, 2020
@lunny lunny force-pushed the lunny/move_code_index_queue branch from 7717f2e to 94b88b3 Compare July 22, 2020 06:22
@lunny lunny force-pushed the lunny/move_code_index_queue branch from be63a42 to 775036f Compare July 26, 2020 09:07
@lunny
Copy link
Member Author

lunny commented Jul 26, 2020

@lafriks done.

@lafriks
Copy link
Member

lafriks commented Jul 26, 2020

Tests seem to be broken

@lunny lunny force-pushed the lunny/move_code_index_queue branch 3 times, most recently from 475f952 to 16903c4 Compare September 6, 2020 09:38
@codecov-commenter
Copy link

Codecov Report

Merging #10332 into master will decrease coverage by 0.00%.
The diff coverage is 32.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10332      +/-   ##
==========================================
- Coverage   43.40%   43.40%   -0.01%     
==========================================
  Files         648      647       -1     
  Lines       71569    71606      +37     
==========================================
+ Hits        31067    31081      +14     
- Misses      35472    35493      +21     
- Partials     5030     5032       +2
Impacted Files Coverage Δ
models/migrations/v111.go 0.00% <0.00%> (ø)
modules/indexer/code/elastic_search.go 0.00% <0.00%> (ø)
modules/indexer/code/indexer.go 35.22% <36.47%> (-0.95%) ⬇️
modules/queue/queue.go 33.33% <50.00%> (+8.94%) ⬆️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/log/event.go 56.60% <0.00%> (-1.89%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
models/error.go 35.32% <0.00%> (+0.51%) ⬆️
modules/git/repo.go 50.76% <0.00%> (+1.01%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc4aad...16903c4. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Sep 6, 2020

It's ready to review.

zeripath
zeripath approved these changes Sep 6, 2020
View reviewed changes
integrations/mssql.ini.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2020
@lunny lunny force-pushed the lunny/move_code_index_queue branch from 16903c4 to 6c7c5c8 Compare September 7, 2020 12:13
@lunny
Copy link
Member Author

lunny commented Sep 7, 2020

Make L-G-T-M work

@lunny lunny merged commit 91e7ad5 into go-gitea:master Sep 7, 2020
@lunny lunny deleted the lunny/move_code_index_queue branch September 7, 2020 15:05
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @lafriks @codecov-commenter @zeripath @6543 @GiteaBot