Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protected branch status check settings #10341

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

jolheiser
Copy link
Member

When enabling status checks in branch protection, currently you have to enable, save, then check the required contexts and save again.

This PR enables selecting contexts at the same time as enabling the protection.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2020
@jolheiser jolheiser merged commit 29efa9c into go-gitea:master Feb 18, 2020
@jolheiser jolheiser deleted the protected_context branch February 18, 2020 18:58
jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 18, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Feb 18, 2020
zeripath pushed a commit that referenced this pull request Feb 18, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants