Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #10363

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Fix test #10363

merged 1 commit into from
Feb 19, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 19, 2020

This PR try to fix the deadlock on sqlite test on CI.

@lunny lunny added the type/bug label Feb 19, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #10363 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10363      +/-   ##
==========================================
+ Coverage   43.74%   43.76%   +0.02%     
==========================================
  Files         585      585              
  Lines       81023    81024       +1     
==========================================
+ Hits        35440    35460      +20     
+ Misses      41202    41169      -33     
- Partials     4381     4395      +14
Impacted Files Coverage Δ
models/repo.go 51.32% <0%> (-0.04%) ⬇️
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-9.38%) ⬇️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
models/notification.go 64.13% <0%> (-1.06%) ⬇️
models/pull.go 42.37% <0%> (+0.55%) ⬆️
services/mirror/mirror.go 19.4% <0%> (+0.65%) ⬆️
models/repo_mirror.go 12.76% <0%> (+10.63%) ⬆️
services/pull/check.go 53.04% <0%> (+14.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17445bb...71c2494. Read the comment docs.

@techknowlogick techknowlogick merged commit 8db20e8 into go-gitea:master Feb 19, 2020
@lunny lunny deleted the lunny/fix_test branch February 19, 2020 16:11
@techknowlogick techknowlogick added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 19, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants