Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes in login sources (#10428) #10429

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Various fixes in login sources (#10428) #10429

merged 1 commit into from
Feb 23, 2020

Conversation

zeripath
Copy link
Contributor

Backport #10428

Several fixes in login sources affecting PAM and SMTP authentication.

@zeripath zeripath added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Feb 23, 2020
@zeripath zeripath added this to the 1.11.2 milestone Feb 23, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2020
@lafriks lafriks merged commit d3b6f00 into go-gitea:release/v1.11 Feb 23, 2020
@zeripath zeripath deleted the backport-10428 branch February 23, 2020 21:33
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @guillep2k @jolheiser @lafriks @GiteaBot