Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markbates/goth (#10444) #10445

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Update markbates/goth (#10444) #10445

merged 1 commit into from
Feb 24, 2020

Conversation

oscarlofwenhamn
Copy link
Contributor

Update markbates/goth to v1.61.2

  • Fixes a JWT decoding issue in the OpenID provider
  • Updates the GitHub provider to use the authorization header for authentication
  • Updates the Twitch provider for Twitch's v5 API changes
  • Adds the email and is_private_email fields to the Apple provider's GetUser implementation
  • Modifies gothic to export a non-collidable context key for setting the Provider in a context.Context
  • Adds new scopes to the Spotify provider
  • Adds the IDToken from OpenID providers on the user struct
  • Make Apple provider's SecretParams public
  • Adds support for sign in with Apple, and drops support for Go versions 1.7 and 1.8
  • Fixes the Slack provider's FetchURL logic to use the appropriate scope for the info it needs

Update markbates/goth (backport)
80f84cd 
Update markbates/goth to v1.61.2
- Fixes a JWT decoding issue in the OpenID provider
- Updates the GitHub provider to use the authorization header for authentication
- Updates the Twitch provider for Twitch's v5 API changes
- Adds the email and is_private_email fields to the Apple provider's GetUser implementation
- Modifies gothic to export a non-collidable context key for setting the Provider in a context.Context
- Adds new scopes to the Spotify provider
- Adds the IDToken from OpenID providers on the user struct
- Make Apple provider's SecretParams public
- Adds support for sign in with Apple, and drops support for Go versions 1.7 and 1.8
- Fixes the Slack provider's FetchURL logic to use the appropriate scope for the info it needs
Signed-off-by: Oscar LÃfwenhamn <oscar.lofwenhamn@cgi.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 24, 2020
@techknowlogick techknowlogick added this to the 1.11.2 milestone Feb 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2020
@techknowlogick techknowlogick merged commit 3abb251 into go-gitea:release/v1.11 Feb 24, 2020
@zeripath zeripath changed the title Update markbates/goth (backport v1.11) Update markbates/goth (#10444) Mar 6, 2020
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.
6 participants
@oscarlofwenhamn @techknowlogick @6543 @jolheiser @zeripath @GiteaBot