Fix the signing icon in the view_list.tmpl page #10511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
the
skip-changelog
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Feb 27, 2020
GiteaBot
added
lgtm/need 1
|
Cog fix: .sha.label i.icon.centerlock {
top: 10px;
} |
|
Centering looking good with this. |
|
@silverwind are you having the cog misplaced? |
|
It's just a OCD tweak to center it on the lock's "body". 1.5em:
10px: 1.45em (best): |
|
done |
silverwind
reviewed
Feb 27, 2020
as per @silverwind Co-Authored-By: silverwind <me@silverwind.io>
lafriks
approved these changes
Feb 27, 2020
GiteaBot
added
lgtm/done
silverwind
approved these changes
Feb 27, 2020
|
Ping LG-TM |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 28, 2020
Backport go-gitea#10425 Backport go-gitea#10511 * Show Signer in commit lists and add basic trust (go-gitea#10425) Show the avatar of the signer in the commit list pages as we do not enforce that the signer is an author or committer. This makes it clearer who has signed the commit. Also display commits signed by non-members differently from members and in particular make it clear when a non-member signer is different from the committer to help reduce the risk of spoofing. Signed-off-by: Andrew Thornton <art27@cantab.net> Fix the signing icon in the view_list.tmpl page (go-gitea#10511) Co-Authored-By: silverwind <me@silverwind.io> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
guillep2k
added a commit
that referenced
this pull request
Feb 28, 2020
Backport #10425 Backport #10511 * Show Signer in commit lists and add basic trust (#10425) Show the avatar of the signer in the commit list pages as we do not enforce that the signer is an author or committer. This makes it clearer who has signed the commit. Also display commits signed by non-members differently from members and in particular make it clear when a non-member signer is different from the committer to help reduce the risk of spoofing. Signed-off-by: Andrew Thornton <art27@cantab.net> Fix the signing icon in the view_list.tmpl page (#10511) Co-Authored-By: silverwind <me@silverwind.io> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 29, 2020
Unfortunately the fix in go-gitea#10511 was slightly incorrect and placed the detail box at one level too far out. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Feb 29, 2020
Unfortunately the fix in #10511 was slightly incorrect and placed the detail box at one level too far out. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 29, 2020
Unfortunately the fix in go-gitea#10511 was slightly incorrect and placed the detail box at one level too far out. Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
pushed a commit
that referenced
this pull request
Feb 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a slight inconsistency introduced with the position of the signing avatar in #10425.
This fixes it.