Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to fix the old broken merge-bases #10604

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 4, 2020

#10586 fixed the merge-bases for current PRs but did not fix the merge-base for merged PRs.

This PR adds a new migration that will run through all PRs in the system and recalculates the merge-bases.

@zeripath zeripath added this to the 1.12.0 milestone Mar 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #10604 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10604      +/-   ##
==========================================
- Coverage    43.7%   43.69%   -0.02%     
==========================================
  Files         585      586       +1     
  Lines       82031    82098      +67     
==========================================
+ Hits        35852    35870      +18     
- Misses      41737    41788      +51     
+ Partials     4442     4440       -2
Impacted Files Coverage Δ
models/migrations/migrations.go 4.16% <ø> (ø) ⬆️
models/migrations/v128.go 0% <0%> (ø)
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-9.38%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
models/notification.go 64.71% <0%> (+0.83%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa1e1a...4806b80. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2020
models/migrations/v128.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2020
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2020
@lafriks
Copy link
Member

lafriks commented Mar 5, 2020

make LG-TM work

@lafriks lafriks merged commit 6420f17 into go-gitea:master Mar 5, 2020
@zeripath zeripath deleted the fix-merge-base-migration branch March 5, 2020 07:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants