-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure executable bit is kept on the web editor #10607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
the
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
label
Mar 4, 2020
lafriks
added
type/enhancement
An improvement of existing functionality
type/bug
and removed
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
type/enhancement
An improvement of existing functionality
labels
Mar 4, 2020
lafriks
approved these changes
Mar 4, 2020
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Mar 4, 2020
guillep2k
approved these changes
Mar 4, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 4, 2020
sapk
approved these changes
Mar 4, 2020
7 tasks
I think this could be backported |
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Mar 5, 2020
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
lunny
added a commit
that referenced
this pull request
Mar 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a file with the editor - if the file had an executable bit keep it set.
Fix #7771