Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users with write permissions to modify issue descriptions and comments #10623

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

jolheiser
Copy link
Member

Users with write perms to issues can modify issue descriptions and comments.

Resolves #10558

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Mar 6, 2020
@lunny lunny merged commit f422a11 into go-gitea:master Mar 6, 2020
@lunny
Copy link
Member

lunny commented Mar 6, 2020

Please send backport.

jolheiser added a commit to jolheiser/gitea that referenced this pull request Mar 6, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
zeripath pushed a commit that referenced this pull request Mar 6, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@lafriks lafriks added the backport/done All backports for this PR have been created label Mar 6, 2020
@zeripath zeripath changed the title Fix modifying issues Allow users with write permissions to modify issue descriptions and comments. Mar 6, 2020
@zeripath zeripath changed the title Allow users with write permissions to modify issue descriptions and comments. Allow users with write permissions to modify issue descriptions and comments Mar 6, 2020
@brunoais
Copy link

brunoais commented Mar 6, 2020

@lunny I'm not sure but does this allow any user who can create issues to edit other user's issue descriptions?

@lafriks
Copy link
Member

lafriks commented Mar 6, 2020

@brunoais no, it allows users with write access to issues to edit other users descriptions. Issue can be created with read access.

@6543
Copy link
Member

6543 commented Mar 6, 2020

We may have to specify zhis in future ... (spam protection & co ...)

@guillep2k
Copy link
Member

@brunoais It's not intuitive, but "read" permissions include creating issues and editing/closing own issues. "Write" permissions include modifying/closing issues from other users.

@brunoais
Copy link

brunoais commented Mar 6, 2020

Thank you @lafriks & @guillep2k . It is really not intuitive... I think I'm giving too many permissions to my users, then...

@lafriks
Copy link
Member

lafriks commented Mar 6, 2020

@brunoais that how it was also before and also same as it is for github

@lafriks
Copy link
Member

lafriks commented Mar 6, 2020

If you need for users only to be able to create issues and update their own, just set them read rights for issues

@brunoais
Copy link

brunoais commented Mar 6, 2020

Used github a lot. Never managed accounts on github (I never owned any repo without it being a clone an/or public repo)

@guillep2k
Copy link
Member

I think we should improve the way the permissions for groups are presented in the UI.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to edit issue description anymore
8 participants