-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for LDAP group membership #10869
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10869 +/- ##
========================================
Coverage 43.39% 43.40%
========================================
Files 593 593
Lines 83276 83392 +116
========================================
+ Hits 36141 36198 +57
- Misses 42643 42696 +53
- Partials 4492 4498 +6
Continue to review full report at Codecov.
|
I think we should take another look at #8814 which appears to do the same thing but also updates the cli commands and includes tests |
That's fine with me, however I don't know if I have the time to resolve those conflicts at the moment. |
Closing in favor of #8814 |
I think we should reopen this and get it merged as #8814 appears to be stuck. |
Codecov Report
@@ Coverage Diff @@
## master #10869 +/- ##
==========================================
- Coverage 43.24% 43.24% -0.01%
==========================================
Files 650 650
Lines 72050 72099 +49
==========================================
+ Hits 31157 31176 +19
- Misses 35851 35877 +26
- Partials 5042 5046 +4
Continue to review full report at Codecov.
|
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-Authored-By: Lauris BH <lauris@nix.lv> Co-Authored-By: zeripath <art27@cantab.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment
This is a port of gogs/gogs#4398
The only changes made by myself are:
Otherwise all code credit goes to @aboron
Resolves #10829