Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: include LFS when calculating repo size #11060

Merged
merged 3 commits into from
May 31, 2020
Merged

models: include LFS when calculating repo size #11060

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0168b53
models: include LFS when calculating repo size
cuonglm Apr 13, 2020
572a98c
Merge branch 'master' into cuonglm/issue-9369
jolheiser May 21, 2020
03e2916
Merge branch 'master' into cuonglm/issue-9369
techknowlogick May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions models/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,14 @@ func (repo *Repository) updateSize(e Engine) error {
return fmt.Errorf("updateSize: %v", err)
}

objs, err := repo.GetLFSMetaObjects(-1, 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A select sum sql is better than this change.

if err != nil {
return fmt.Errorf("updateSize: GetLFSMetaObjects: %v", err)
}
for _, obj := range objs {
size += obj.Size
}

repo.Size = size
_, err = e.ID(repo.ID).Cols("size").Update(repo)
return err
Expand Down