Fix submodule paths when AppSubUrl is not root #11098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#11002 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Unit test failing (related) |
GiteaBot
added
the
lgtm/need 2
This comment has been minimized.
This comment has been minimized.
6543
approved these changes
Apr 20, 2020
| @@ -51,14 +52,10 @@ func getRefURL(refURL, urlPrefix, parentPath string) string { | |||
| urlPrefixHostname = prefixURL.Host | |||
| } | |||
|
|
|||
| // FIXME: Need to consider branch - which will require changes in modules/git/commit.go:GetSubModules | |||
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #11098 +/- ##
==========================================
- Coverage 43.44% 43.24% -0.21%
==========================================
Files 600 601 +1
Lines 85135 85599 +464
==========================================
+ Hits 36988 37015 +27
- Misses 43575 44016 +441
+ Partials 4572 4568 -4
Continue to review full report at Codecov.
|
guillep2k
approved these changes
Apr 22, 2020
| @@ -69,16 +66,16 @@ func getRefURL(refURL, urlPrefix, parentPath string) string { | |||
|
|
|||
| m := match[0] | |||
| refHostname := m[2] | |||
| path := m[3] | |||
| pth := m[3] | |||
GiteaBot
added
lgtm/done
|
ping lgtm |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 22, 2020
Backport go-gitea#11098 Fix go-gitea#11002 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Apr 22, 2020
5 tasks
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Fix submodule paths when AppSubUrl is not root Fix go-gitea#11002 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11002
Signed-off-by: Andrew Thornton art27@cantab.net