Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When deleting a tracked time through the API return 404 not 500 #11319

Merged
merged 3 commits into from
May 7, 2020
Merged

When deleting a tracked time through the API return 404 not 500 #11319

merged 3 commits into from
May 7, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 7, 2020

as title

@6543 6543 mentioned this pull request May 7, 2020
Closed
7 tasks
@zeripath zeripath changed the title [Fix] [API] return 404 not 500 if trackedTime not exist When deleting a tracked time through the API return 404 not 500 May 7, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 7, 2020
@zeripath zeripath added the modifies/api This PR adds API routes or modifies them label May 7, 2020
@zeripath zeripath added this to the 1.12.0 milestone May 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2020
@zeripath
Copy link
Contributor

zeripath commented May 7, 2020

make lg-tm work

@zeripath zeripath merged commit 486e4c8 into go-gitea:master May 7, 2020
@zeripath
Copy link
Contributor

zeripath commented May 7, 2020

Please send backport 😛

@6543 6543 deleted the fix-trackedtime_unintended-500 branch May 7, 2020 18:13
6543 added a commit to 6543-forks/gitea that referenced this pull request May 7, 2020
@6543
When delete tracked time through the API return 404 not 500 (go-gitea…
724dd81 
…#11319)
@6543 6543 mentioned this pull request May 7, 2020
Merged
@6543
Copy link
Member Author

6543 commented May 7, 2020

Backport #11326

@lafriks lafriks added the backport/done All backports for this PR have been created label May 7, 2020
lafriks pushed a commit that referenced this pull request May 7, 2020
@6543
When delete tracked time through the API return 404 not 500 (#11319) (#…
79868d7 
…11326)
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
When deleting a tracked time through the API return 404 not 500 (go-g…
9f11546 
…itea#11319)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @zeripath @guillep2k @lafriks @GiteaBot