Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random avatars #1147

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Fix random avatars #1147

merged 1 commit into from
Mar 8, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 8, 2017

This will fix random avatars bug and resolve #1131

@lunny lunny added the type/bug label Mar 8, 2017
@lunny lunny added this to the 1.1.0 milestone Mar 8, 2017
@andreynering
Copy link
Contributor

Trusted LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 8, 2017
@appleboy
Copy link
Member

appleboy commented Mar 8, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2017
@lunny lunny merged commit 5d40db6 into go-gitea:master Mar 8, 2017
@lunny lunny deleted the lunny/fix_random_avatar branch April 19, 2017 05:51
Copy link

@fredounnet fredounnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I don't exactly know where, but that code modification doesn't honnor the envar GITEA_CUSTOM.
I can't create organisations anymore from 1.1.0 to 1.1.1. HTTP 500

2017/05/12 12:27:45 [...a/routers/org/org.go:60 CreatePost()] [E] CreateOrganization: generate random avatar: MkdirAll: mkdir /home/xxx/gitea/data: permission denied

gitea runs under systemd control with :
Environment=GITEA_CUSTOM=/home/xxx/gitea

In fact the picture.AVATAR_UPLOAD_PATH entry seems to became mandatory. Then set, there is
no more 500 status.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants