Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text-transform on wiki revisions page #11486

Merged
merged 8 commits into from
May 20, 2020
Merged

Fix text-transform on wiki revisions page #11486

merged 8 commits into from
May 20, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 18, 2020 •
edited
Loading

Fixes this:
firefox_2020-05-18_16-21-06

Identical style is already applied to .view page but .revisions was missed.

@silverwind
Copy link
Member

Maybe just override them all using .ui.sub.header selector? It seems like a rather opinionated style of fomantic.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 18, 2020 •
edited
Loading

Unsure if we depend on it anywhere, which is why i have not done it. Anything comes to mind? Personally I don't think I've ever seen it

Looks like it's only on wiki, so we can go ahead. It's interesting that this is set only on combination of these 3, .ui .sub.header won't have that styling.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2020
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label May 19, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone May 19, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit c7c6177 into go-gitea:master May 20, 2020
@CirnoT CirnoT deleted the wiki-revisions_text-transform branch May 20, 2020 21:11
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @techknowlogick @zeripath
Fix text-transform on wiki revisions page (go-gitea#11486)
8bc51c0 
* Fix text-transform on wiki revisions page

* apply global

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CirnoT @silverwind @techknowlogick @zeripath @GiteaBot