Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropzone color on arc-green #11514

Merged
merged 4 commits into from
May 19, 2020
Merged

Fix dropzone color on arc-green #11514

merged 4 commits into from
May 19, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 19, 2020 •
edited
Loading

Before:
chrome_2020-05-19_18-29-13

After:
chrome_2020-05-19_22-38-15

@silverwind
Copy link
Member

Thanks, this has been bothering me as well. Maybe go a bit darker on the background, e.g. same color as the textarea above.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 19, 2020

Updated background-color to match textarea and changed border color to be more visible, following how it's done in light theme.

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 19, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 19, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit c572ee2 into go-gitea:master May 19, 2020
@CirnoT CirnoT deleted the dropzone-arc-green branch May 19, 2020 23:25
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @techknowlogick
Fix dropzone color on arc-green (go-gitea#11514)
dd032ed 
* Fix dropzone color on arc-green

* fix missing ;

* use same color as textarea and fix border

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CirnoT @silverwind @techknowlogick @zeripath @GiteaBot