Style code review comment for arc-green #11572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The border around "Review" should be light, not dark. Otherwise it looks like a good improvement. |
GiteaBot
added
the
lgtm/need 2
|
There seems to be unneeded margin between comment author and content |
|
Changed border color around "Review" tag to be light and adjusted border around textarea to match proposed changes in #11570 Updated screenshot in first comment |
6543
approved these changes
May 23, 2020
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
May 24, 2020
GiteaBot
added
lgtm/done
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Style code review comment for arc-green * change border around review for light; update border around textarea to match go-gitea#11570 Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lot of styling fixes in this one, but I'd like to think I got it somewhat usable.
Before:
After:
Few issues that still remain should be fixed by #11570 and #11571