Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full GPG commit status on PR commit history #11702

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Show full GPG commit status on PR commit history #11702

merged 5 commits into from
Jun 3, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 31, 2020

chrome_2020-05-31_02-27-20

chrome_2020-05-31_02-28-18

silverwind
silverwind reviewed May 31, 2020
View reviewed changes
templates/repo/commits_list_small.tmpl Outdated
{{else}}
<i title="{{$.root.i18n.Tr .Verification.Reason}}" class="unlock icon"></i>
{{end}}
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to extract this badge to its own template file? This is the third occurence of it. DRY 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested templates within nested template within nested template within nested template :>

Will try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good at first glance. Will test later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 2, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Jun 2, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 2, 2020
@lafriks
Copy link
Member

lafriks commented Jun 2, 2020

Make lgtm work

@techknowlogick techknowlogick merged commit d0a18a1 into go-gitea:master Jun 3, 2020
@CirnoT CirnoT deleted the pr-commits-sign branch June 3, 2020 00:27
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @zeripath @lafriks
Show full GPG commit status on PR commit history (go-gitea#11702)
3d520af 
* Show full GPG commit status on PR commit history

* move shabox badge to separate template

* unnecessary $

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@CirnoT @lafriks @silverwind @zeripath @techknowlogick @GiteaBot