Honor DEFAULT_PAGING_NUM for API #11805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Jun 8, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Jun 8, 2020
GiteaBot
added
lgtm/done
techknowlogick
approved these changes
Jun 8, 2020
|
Should we get rid of tests like |
|
Yeah, or instead of getting rid of them have it test the settings variable. |
|
Testing the setting variable won't work because it might be larger than amount of repos during test in which case we'll pass regardless whether the default works or is too big to get into effect. |
6543
approved these changes
Jun 8, 2020
6543
reviewed
Jun 8, 2020
|
ping LG-TM |
|
@CirnoT please send backport :) |
CirnoT
added a commit
to CirnoT/gitea
that referenced
this pull request
Jun 9, 2020
* Honor DEFAULT_PAGING_NUM for API * set pagination to 10 for tests * lint Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io> (cherry picked from commit cefbf73)
lafriks
pushed a commit
that referenced
this pull request
Jun 9, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Honor DEFAULT_PAGING_NUM for API * set pagination to 10 for tests * lint Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it was hardcoded to 10