Fix commit search in all branches #11849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand correctly it will just change only argument order but does not really changes |
GiteaBot
added
the
lgtm/need 2
|
Expand diff below, the same args are used for two commands - this PR makes it so that |
|
|
|
OK I think that code needs comments as to what the hell it is doing. It's really not clear! (Not your fault but as you've spent the time to understand this - you may be best placed to expand the commentary and make this clearer.) |
|
Added comments; pretty detailed ones too. |
|
Hopefully now you see that --all breaks logic of |
zeripath
approved these changes
Jun 11, 2020
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix commit search in all branches * comments Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We perform two commands on commit search,
--allshould not be used without--grep.Fixes case where searching for commit with 'All Branches' selected would always return newest commit from newest ref instead of correct commit.