API: Move AllowedReactions endpoint into GetGenneralUI endpoint + creat new swagger section settings #11854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
changed the title
GiteaBot
added
the
lgtm/need 2
|
@mrsdizzie ping WIP because if there are more usefull settings to expose in the UI scope: -> change GetAllowedReactions to a getGeneralUISettings ... |
|
@6543 that change is fine but I mean that you shouldn't have an endpoint for one single setting like /settings/allowed_reactions -- it should be /settings/ui that can return That way you can eventually add other settings without having to create new endpoints for each one, just like how the check for mirrors uses /settings/repository. I only pick 'ui' because that is the section in config.ini just as repository is for the other example |
6543
changed the title
6543
changed the title
|
@mrsdizzie done |
|
Test fail changes seem good otherwise |
|
@mrsdizzie passed - fail seems unrelated |
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jun 22, 2020
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
|
🚀 |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…at new swagger section settings (go-gitea#11854) * move Setting function into its own package * swagger add&use new section "settings" * move api AllowedReactions into general UI-Settings endpoint * prepare TEST * lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
come up in #11758 (comment)