Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move license.txt to misc and update reserved usernames/known entries #11872

Closed
wants to merge 5 commits into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jun 12, 2020

  • Move license.txt from /js to /misc
  • Update reserved usernames to match public entries
  • Update list of known public entries for bindata router

I hope this is the last time we need to change the reserved usernames and we can put all new files in /misc/.

@silverwind silverwind changed the title Move licence.txt to misc and update reserved usernames/known entries Move license.txt to misc and update reserved usernames/known entries Jun 12, 2020
- Move license.txt from /js to /misc
- Update reserved usernames to match public entries
- Update list of known public entries for bindata router

I hope this is the last time we need to change the reserved usernames
and we can put all new files in /misc/.
@silverwind
Copy link
Member Author

silverwind commented Jun 12, 2020

Removed the public/fonts directory which also frees up the reserved username name "fonts". This only affects by monaco's font which is moved to misc/codicon.ttf.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2020
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should avoid creating more reserved user names. Is there really no way of using what we already have without making misc reserved? I can easily imagine that someone already has an organisation called misc.

We cannot just keep adding to these lists and need to consider if we can actually reduce the size of these lists considerably.

@silverwind
Copy link
Member Author

silverwind commented Jun 12, 2020

Could move everything to a single subdirectory like public/assets served as /assets which would free up everything except assets and serviceworker.js.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2020
@zeripath
Copy link
Contributor

Yeah I think putting it in assets would be better - tbh we could move more out to that that would be better.

This reserved-usernames stuff annoys me - it's really not hard to structure urls in such a way that this isn't necessary. For example we should have structured our urls as "~owner/reponame" instead of "owner/reponame" and then a lot of things would have been easier overall and/or enforced that names had to start with a letter and not an underscore and then we could have all of our stuff start with an underscore.

I guess we could prefix all of our stuff with a ! and/or consider a move to prefixed tilde in future.

Sigh.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes if we use 'assets' we wont have a next reserved username

and i like the refactor done at https://github.com/go-gitea/gitea/pull/11872/files#diff-46259196476f860fea33754fcb22e9eeR917

@silverwind
Copy link
Member Author

I think "assets" isn't so bad. Another option may be "static" which would fit a bit better with the existing STATIC_URL_PREFIX option.

@silverwind
Copy link
Member Author

Moving to a assets directory will be more work and may require breaking changes. I'll open another PR with just the KnownEntries change which is still valuable.

@silverwind silverwind closed this Jun 20, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants