-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move license.txt to misc and update reserved usernames/known entries #11872
Conversation
- Move license.txt from /js to /misc - Update reserved usernames to match public entries - Update list of known public entries for bindata router I hope this is the last time we need to change the reserved usernames and we can put all new files in /misc/.
Removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should avoid creating more reserved user names. Is there really no way of using what we already have without making misc reserved? I can easily imagine that someone already has an organisation called misc.
We cannot just keep adding to these lists and need to consider if we can actually reduce the size of these lists considerably.
Could move everything to a single subdirectory like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
Yeah I think putting it in assets would be better - tbh we could move more out to that that would be better. This reserved-usernames stuff annoys me - it's really not hard to structure urls in such a way that this isn't necessary. For example we should have structured our urls as "~owner/reponame" instead of "owner/reponame" and then a lot of things would have been easier overall and/or enforced that names had to start with a letter and not an underscore and then we could have all of our stuff start with an underscore. I guess we could prefix all of our stuff with a ! and/or consider a move to prefixed tilde in future. Sigh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes if we use 'assets' we wont have a next reserved username
and i like the refactor done at https://github.com/go-gitea/gitea/pull/11872/files#diff-46259196476f860fea33754fcb22e9eeR917
I think "assets" isn't so bad. Another option may be "static" which would fit a bit better with the existing |
Moving to a assets directory will be more work and may require breaking changes. I'll open another PR with just the |
I hope this is the last time we need to change the reserved usernames and we can put all new files in /misc/.