Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write to global gitconfig if necessary #11876

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 13, 2020

Only write to the global gitconfig if necessary.

Also make it possible to unwrap the error returned from process execs to get to the underlying *exec.ExitError.

Fix #11855

@zeripath zeripath added this to the 1.13.0 milestone Jun 13, 2020
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Jun 13, 2020
@zeripath zeripath force-pushed the fix-11855-only-write-to-global-if-necessary branch from 315aaa7 to 253805c Compare June 13, 2020 09:52
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 13, 2020
@zeripath zeripath force-pushed the fix-11855-only-write-to-global-if-necessary branch from 253805c to cf67e28 Compare June 13, 2020 09:57
Fix go-gitea#11855

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath force-pushed the fix-11855-only-write-to-global-if-necessary branch from cf67e28 to cfc61cf Compare June 13, 2020 10:16
zeripath and others added 2 commits June 13, 2020 11:20
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2020
@techknowlogick techknowlogick merged commit ae3cfa8 into go-gitea:master Jun 13, 2020
@zeripath zeripath deleted the fix-11855-only-write-to-global-if-necessary branch June 13, 2020 22:43
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Only write to global gitconfig if necessary

Fix go-gitea#11855

Signed-off-by: Andrew Thornton <art27@cantab.net>

* placate lint

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@micheelengronne
Copy link

When will it be available in a release ?

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitea and read-only filsystems
5 participants