-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename custom/conf/app.ini.sample to custom/conf/app.example.ini for better syntax light on editor #11926
Conversation
Need to update docs and |
While we're renaming this, I'd prefer |
Maybe app.default.ini? since these aren't just examples/samples but actually contain the default values in use for everything (and makes it obvious to look there for all default settings) |
I think the general expectance is that users copy the file to the actual config file and in this case, I think "example" fits better than "default" as I don't think gitea can run or do anything useful without a config file (or the equivalent env vars). |
Users really should not copy the app.ini.sample as the default. We really should not encourage that! If we want to provide them with a basic app.ini we should do that. |
Why not? It gets you a full set of options. It's a perfect starting point imho :) |
I've always just gone with the minimal one generated with installation and then added settings as needed. I don't like the clutter of a bunch of settings that are all default if I can avoid it, if only because our config is massive. |
I see, a minimal approach can be viable as well so fine with naming it "default" as well. |
In most configuration less is more. |
it got my lgtm - like the idear but it will need some update here:
|
6d010e5
to
b9656ab
Compare
ping LG-TM |
…better syntax light on editor (go-gitea#11926) * Rename custom/conf/app.ini.sample to custom/conf/app.sample.ini for better syntax light on editor * rename to app.example.ini * per @6543 's comment, update all references on docs Co-authored-by: techknowlogick <techknowlogick@gitea.io>
As title.