Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom SVGs for commit signing lock icon #12017

Merged
merged 6 commits into from
Jun 28, 2020
Merged

Use custom SVGs for commit signing lock icon #12017

merged 6 commits into from
Jun 28, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jun 22, 2020

chrome_2020-06-22_16-59-59
chrome_2020-06-22_17-00-34
chrome_2020-06-22_17-01-00
chrome_2020-06-22_17-01-47
chrome_2020-06-22_17-03-37
chrome_2020-06-22_17-03-52
chrome_2020-06-22_17-04-18
chrome_2020-06-22_17-04-34

@CirnoT CirnoT mentioned this pull request Jun 22, 2020
Closed
@silverwind
Copy link
Member

Add this to .editorconfig:

[*.svg]
insert_final_newline = false

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 22, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jun 22, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 22, 2020
@silverwind
Copy link
Member

xmlns is not necessary for inline SVG content, you can remove it.

@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 22, 2020 •
edited
Loading

Copying SVG inline from octicons primer website generates it so I've also added it. Also for some reason this allows GoLand to show image preview, for what it's worth.

@silverwind
Copy link
Member

Yeah it's needed for standalone display. It seems svg-sprite-loader already removes the attribute, so it should be fine.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 22, 2020
lunny
lunny reviewed Jun 23, 2020
View reviewed changes
web_src/less/_repository.less
@@ -1479,8 +1479,12 @@
margin-right: 0;
}

.svg {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this change?

Copy link
Contributor Author

@CirnoT CirnoT Jun 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add proper margin on the right of svg inside flex container

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit b918609 into go-gitea:master Jun 28, 2020
@CirnoT CirnoT deleted the gpg-sign-lock-svg branch June 28, 2020 12:08
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @lunny @techknowlogick
Use custom SVGs for commit signing lock icon (go-gitea#12017)
9cf0e9f 
* Use custom SVGs for commit signing lock icon

* missing spans

* editorconfig

* xmlns and remove aria-hidden

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@CirnoT @silverwind @techknowlogick @lunny @lafriks @GiteaBot