Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix U2F button icon #12167

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix U2F button icon #12167

merged 1 commit into from
Jul 6, 2020

Conversation

silverwind
Copy link
Member

I assumed the file being unused but it's apparently in use on the "Add Security Key" button where a USB icon is shown.

@CirnoT please confirm if possible.

@CirnoT
Copy link
Contributor

CirnoT commented Jul 6, 2020

Wouldn't it be better to replace it with something else? Possibly https://primer.style/octicons/key-16
Seems a waste to use it just for a single icon.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 6, 2020
@silverwind
Copy link
Member Author

Okay, did that and also fixed the button color on arc-green (it only styles green buttons, not positive ones).

image

@silverwind
Fix U2F button icon
3889ef1 
Previously this used a USB icon which required a separate font file used
nowhere else so replace it with a octicon and fix the background color
on arc-green too.
@silverwind silverwind changed the title Include brand-icons in build Fix U2F button icon Jul 6, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 6, 2020
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 6, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jul 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 6, 2020
@lafriks lafriks merged commit 075f33c into go-gitea:master Jul 6, 2020
@silverwind silverwind deleted the brandicons branch July 7, 2020 05:52
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind
Fix U2F button icon (go-gitea#12167)
ef37f0f 
Previously this used a USB icon which required a separate font file used
nowhere else so replace it with a octicon and fix the background color
on arc-green too.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @CirnoT @techknowlogick @lafriks @GiteaBot