-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for push options #12169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser
added
the
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
label
Jul 6, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
lunny
reviewed
Jul 9, 2020
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 9, 2020
CirnoT
reviewed
Jul 11, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
mrsdizzie
reviewed
Aug 18, 2020
Co-authored-by: mrsdizzie <info@mrsdizzie.com>
mrsdizzie
approved these changes
Aug 18, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Aug 18, 2020
lunny
previously requested changes
Aug 18, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
zeripath
approved these changes
Aug 20, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #12169 +/- ##
==========================================
- Coverage 43.43% 43.43% -0.01%
==========================================
Files 644 644
Lines 71203 71246 +43
==========================================
+ Hits 30925 30943 +18
- Misses 35263 35287 +24
- Partials 5015 5016 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #12160
This PR will add some support for push options.
Currently it is limited to changing repo visibility and whether it is a template or not, however more could be added in the future.