Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forget migration for wiki hooks (#1227) #1237

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Fix forget migration for wiki hooks (#1227) #1237

merged 1 commit into from
Mar 17, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 13, 2017

back port from #1227

@lunny lunny added the type/bug label Mar 13, 2017
@lunny lunny added this to the 1.1.1 milestone Mar 13, 2017
@strk
Copy link
Member

strk commented Mar 13, 2017

Adding a migration in a point release ? Is it really needed to be in 1.1.1 ? Wouldn't it confuse things (ie: which database version is in which X.Y release ?)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 13, 2017
@lunny
Copy link
Member Author

lunny commented Mar 13, 2017

@strk this is a backport. I think it should be needed.

@andreynering
Copy link
Contributor

Trusted LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2017
@lunny lunny force-pushed the lunny/fix_wiki_repo_hooks1 branch from 18778e2 to 837b280 Compare March 17, 2017 02:20
@lunny
Copy link
Member Author

lunny commented Mar 17, 2017

let L-G-T-M work

@lunny lunny merged commit 5fad542 into go-gitea:release/v1.1 Mar 17, 2017
@lunny lunny deleted the lunny/fix_wiki_repo_hooks1 branch April 19, 2017 05:52
ethantkoenig pushed a commit to ethantkoenig/gitea that referenced this pull request Apr 29, 2017
@lunny
fix forget migration for wiki hooks (go-gitea#1227) (go-gitea#1237)
21b6923
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @strk @andreynering @appleboy @tboerger