-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserProfile Page: Render Description #12415
Conversation
It's called Biography in Settings but internaly named Description everywhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good feature, I like it. Thanks. 🎉
After this change suggest adding simpleMDE support for description edit box.
If this is supposed to mimic GitHub's recent profile README's, I suggest putting it into a box on the right instead of cramming it into that small box. It should not render at all if the text is empty.
Please don't for now. We want to get rid of SimpleMDE, not make it harder to migrate off it. |
@silverwind now it only render if Description has text in it |
@lunny @a1012112796 hope you dont mind the change after your LGTM? |
I see, it's reasonable. I think maybe we can add some note messages on the edit box to let users know the user's description support markdown rules. |
I guess this is fine for now, our user profile page will need a rework anyways to allow adding one more tab to it (e.g. create a "Overview" tab and move both profile readme and activity to it, maybe convert Followers/Following into a link to separate pages). |
@6543 I think the tests are genuinely failing here and don't just represent intermittent failures. |
look's like I'll have to dick into it |
Interestint throu that the test fail on points where this PR should NOT produce ANY change ... |
☝️ thats how bug's are produced - in this case the nil exeption didnt let me sleep - catched it |
@lunny you noticed it at the same time :D |
now you can use Markdown to get something like this: