Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG favicon #12437

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Add SVG favicon #12437

merged 2 commits into from
Aug 6, 2020

Conversation

silverwind
Copy link
Member

Browser support is pretty good and the .png icon should still continue to work in unsupporting browser.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 5, 2020
@silverwind
Copy link
Member Author

Should probably call out in the release notes that users who customize the icon have to provide favicon.svg (ideally generated along other images using make generate-images).

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Aug 5, 2020
@zeripath zeripath added this to the 1.13.0 milestone Aug 5, 2020
@zeripath zeripath added the type/changelog Adds the changelog for a new Gitea version label Aug 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2020
@zeripath
Copy link
Contributor

zeripath commented Aug 6, 2020

Make lg-tm work

@zeripath zeripath merged commit f1a42f5 into go-gitea:master Aug 6, 2020
@silverwind silverwind deleted the svgfav branch August 6, 2020 07:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants