Make the default PID file compile-time settable #12485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitea already defaults to the location shown in the example, so the argument doesn't have any effect. Instead point to a custom location to make it more obvious.
…gitea.pid The former one is only kept for backwards compat according to https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s13.html, and is a symlink to `/run/` on modern distributions.
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
topic/build
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12485 +/- ##
==========================================
+ Coverage 43.73% 43.75% +0.02%
==========================================
Files 631 631
Lines 69870 69871 +1
==========================================
+ Hits 30558 30574 +16
+ Misses 34355 34344 -11
+ Partials 4957 4953 -4
Continue to review full report at Codecov.
|
techknowlogick
approved these changes
Aug 13, 2020
GiteaBot
added
lgtm/need 1
CirnoT
approved these changes
Aug 15, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12391 offered to change the default PID file from
/var/run/gitea.pidhowever in discussion it was decided that this could break users of older systems. An alternative was offered that we could make the PID file compile/link time settable.This PR does this, and changes the name of the setting from CustomPID to simply PIDFile. It also updates the from-source docs to show how to change the compiler settings to do this.
Closes #12391