-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set avatar image dimensions #12654
Set avatar image dimensions #12654
Conversation
Set the avatar image dimensions to help browsers avoid layout reflows. Helps page load performance and user experience (less content jank).
Codecov Report
@@ Coverage Diff @@
## master #12654 +/- ##
=======================================
Coverage 43.28% 43.28%
=======================================
Files 646 646
Lines 71625 71625
=======================================
+ Hits 31002 31006 +4
+ Misses 35608 35602 -6
- Partials 5015 5017 +2
Continue to review full report at Codecov.
|
Note for later: We should probably extract avatar rendering to a helper function, e.g. |
🚀 |
Set the avatar image dimensions to help browsers avoid layout reflows. Helps page load performance and user experience (less content jank).
Here’s an animated PNG demonstrating the problem this patch solved. (This is Codebase.org’s theme, but the issue is generic.)