Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cli error for Asciidoctor #12677

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fixes cli error for Asciidoctor #12677

merged 1 commit into from
Sep 2, 2020

Conversation

pre-martin
Copy link
Contributor

The original fix for #8676 introduced illegal arguments for Asciidoctor, causing no rendering at all. This PR fixes the command line arguments so that Asciidoctor properly renders the text. See https://asciidoctor.org/docs/user-manual/#piping-content-through-the-cli as reference.

The original fix for #8676 introduced illegal arguments for Asciidoctor, causing no rendering at all. This PR fixes the command line arguments so that Asciidoctor properly renders the text. See https://asciidoctor.org/docs/user-manual/#piping-content-through-the-cli as reference.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 2, 2020
@zeripath zeripath added the type/docs This PR mainly updates/creates documentation label Sep 2, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12677 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12677      +/-   ##
==========================================
- Coverage   43.32%   43.31%   -0.01%     
==========================================
  Files         646      646              
  Lines       71592    71592              
==========================================
- Hits        31015    31010       -5     
- Misses      35565    35569       +4     
- Partials     5012     5013       +1     
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 35.32% <0.00%> (-0.35%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
services/pull/pull.go 42.26% <0.00%> (+0.23%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3270e7a...748efe3. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 2, 2020
@techknowlogick techknowlogick merged commit a0c4c1c into go-gitea:master Sep 2, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants