-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner ui for admin, repo settings, and user settings page (#1269) #1270
Conversation
I have tested this throughly.Also the changes on most templates are quite simple:
Why the build failedIt is not my fault, I have tested this.
|
LGTM (merge is blocked until alpine fixes their shit 😉 ) |
A demo server: https://staging.geek1011.tk/ , but it will not always be up, so don't count on it. |
LGTM |
Only owners can merge it :( |
Oh, and "team maintainers" (@andreynering and @metalmatze) - I shall note that role (team maintainers) is not mentioned in the CONTRIBUTING file, so it's not really clear how they are elected (please feel free to file an issue to discuss this) |
@strk That role is mentioned, but not in any length, please make an issue 😉 |
fixed #1269 |
@Fastidious US writes "organisations", UK writes "organizations". #NotABug 😂 |
@bkcsoft sorry, it is about the icon too close to the word (#certainlyabug), not the spelling of it (#ofcoursenotabug). |
#offtopic @bkcsoft you have it backwards, American English: organizations, British English: organisations http://writingexplained.org/organisation-vs-organization-difference For a second I thought I had been spelling it "wrong" my whole life, same with grey and gray, I never know which one I am supposed to use... And don't get me started on Aluminum vs Aluminium English = Annoying |
@plessbd thanks for the contribution. 😂 I wasn’t pointing out the spelling of a word, as explained above, but the fact that the |
@Fastidious Ooh that explains it 😆 In any case, I think it's just the icon being broken. Should probably be fixed though 🙂 |
Speaking of the new ui I did, GitHub just changed their search to a horizontal nav. |
Damn, we lost the advantage ! :) |
I will post a video after I test it.https://transfer.sh/EYam0/newui.mp4Please review this asap, because many templates have been modified, and I do not want any conflicts
\cc @bkcsoft @tboerger @lunny @strk