Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Inform user what meaning hourglass on reviews has #12713

Merged
merged 3 commits into from
Sep 4, 2020
Merged

UI: Inform user what meaning hourglass on reviews has #12713

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6518e4a
UI: Inform user what meaning hourglass on reviews has
6543 Sep 4, 2020
761c8fd
Merge branch 'master' into ui-give-review-sandglas-meaning
6543 Sep 4, 2020
8d070c4
Merge branch 'master' into ui-give-review-sandglas-meaning
techknowlogick Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,7 @@ issues.poster = Poster
issues.collaborator = Collaborator
issues.owner = Owner
issues.re_request_review=Re-request review
issues.is_stale = There have been changes to this PR since this review
issues.remove_request_review=Remove review request
issues.remove_request_review_block=Can't remove review request
issues.sign_in_require_desc = <a href="%s">Sign in</a> to join this conversation.
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/issue/view_content/pull.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</div>
<div class="review-item-right">
{{if .Stale}}
<span class="type-icon text grey">
<span class="ui poping up type-icon text grey" data-content="{{$.i18n.Tr "repo.issues.is_stale"}}">
<i class="octicon icon fa-hourglass-end"></i>
</span>
{{end}}
Expand Down